midsuit
/
wms-be
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(user): Update user retrieval and modification to use route parameters instead of context values
Deploy Application / deploy (push) Successful in 21s Details

This commit is contained in:
Habib Fatkhul Rohman 2025-11-04 09:46:08 +07:00
parent 795d8d05e3
commit 8ff66d3775
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
modules/user/controller/user_controller.go
View File

@ -108,9 +108,9 @@ func (c *userController) Register(ctx *gin.Context) {
// @Failure 400 {object} map[string]interface{} // @Failure 400 {object} map[string]interface{}
// @Router /users [get] // @Router /users [get]
func (c *userController) GetAllUser(ctx *gin.Context) { func (c *userController) GetAllUser(ctx *gin.Context) {
clientId := ctx.MustGet("client_id").(string) // clientId := ctx.MustGet("client_id").(string)
var filter = &query.UserFilter{ var filter = &query.UserFilter{
ClientID: clientId, ClientID: ctx.Query("client_id"),
Name: ctx.Query("name"), Name: ctx.Query("name"),
Includes: []string{"Roles"}, Includes: []string{"Roles"},
} }
@ -284,8 +284,8 @@ func (c *userController) Update(ctx *gin.Context) {
return return
} }
userId := ctx.MustGet("user_id").(string) id := ctx.Param("id")
result, err := c.userService.Update(ctx.Request.Context(), req, userId) result, err := c.userService.Update(ctx.Request.Context(), req, id)
if err != nil { if err != nil {
res := utils.BuildResponseFailed(dto.MESSAGE_FAILED_UPDATE_USER, err.Error(), nil) res := utils.BuildResponseFailed(dto.MESSAGE_FAILED_UPDATE_USER, err.Error(), nil)
ctx.JSON(http.StatusBadRequest, res) ctx.JSON(http.StatusBadRequest, res)
@ -307,9 +307,9 @@ func (c *userController) Update(ctx *gin.Context) {
// @Failure 400 {object} map[string]interface{} // @Failure 400 {object} map[string]interface{}
// @Router /users [delete] // @Router /users [delete]
func (c *userController) Delete(ctx *gin.Context) { func (c *userController) Delete(ctx *gin.Context) {
userId := ctx.MustGet("user_id").(string) id := ctx.Param("id")
if err := c.userService.Delete(ctx.Request.Context(), userId); err != nil { if err := c.userService.Delete(ctx.Request.Context(), id); err != nil {
res := utils.BuildResponseFailed(dto.MESSAGE_FAILED_DELETE_USER, err.Error(), nil) res := utils.BuildResponseFailed(dto.MESSAGE_FAILED_DELETE_USER, err.Error(), nil)
ctx.AbortWithStatusJSON(http.StatusBadRequest, res) ctx.AbortWithStatusJSON(http.StatusBadRequest, res)
return return