midsuit
/
julong-lib
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: enhance approval logic in showApprovel function by adding role checks and removing unnecessary console logs

This commit is contained in:
faisolavolut 2025-03-03 11:21:39 +07:00
parent 8b6407144f
commit b218fd8cd4
1 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
utils/conditionalMPR.ts
View File

@ -43,24 +43,23 @@ export const showApprovel = (
const isField = data?.organization_category === "Non Field" ? false : true; const isField = data?.organization_category === "Non Field" ? false : true;
if (data?.status === "NEED APPROVAL") { if (data?.status === "NEED APPROVAL") {
if (data?.department_head && !data?.vp_gm_director) { if (data?.department_head && !data?.vp_gm_director) {
return { if (role.dir) {
approve: return {
action === "reject" approve:
? "REJECTED" action === "reject"
: isField ? "REJECTED"
? "APPROVED" : isField
: "NEED APPROVAL", ? "APPROVED"
level: "Level VP", : "NEED APPROVAL",
}; level: "Level VP",
};
} else {
return null;
}
} else if (data?.vp_gm_director && !data?.ceo) { } else if (data?.vp_gm_director && !data?.ceo) {
return null; return null;
return {
approve: action === "reject" ? "REJECTED" : "APPROVED",
level: "Level VP",
};
} }
} else if (data?.status === "IN PROGRESS") { } else if (data?.status === "IN PROGRESS") {
console.log(data?.requestor_id, get_user("employee.id"));
const isYou = data?.requestor_id === get_user("employee.id"); const isYou = data?.requestor_id === get_user("employee.id");
if (role?.head) if (role?.head)
return { return {
@ -88,7 +87,6 @@ export const showApprovel = (
if (role?.head) { if (role?.head) {
return null; return null;
} }
console.log({ role });
if (isBudget) { if (isBudget) {
if (!data?.hrd_ho_unit_name) { if (!data?.hrd_ho_unit_name) {
return { return {
@ -97,6 +95,7 @@ export const showApprovel = (
}; };
} }
} else { } else {
// off budget
if (data?.department_head && !data?.vp_gm_director) { if (data?.department_head && !data?.vp_gm_director) {
return { return {
approve: approve: