Commit Graph

263 Commits

Author SHA1 Message Date
hengsin 89e6e6209f IDEMPIERE-6263 Wrong line net amount (#2490) 2024-10-30 14:15:03 +01:00
Carlos Ruiz aaaecb42e9 IDEMPIERE-2981 Implement JSON Field type + IDEMPIERE-6227 - fixes (#2449)
* IDEMPIERE-2981 Implement JSON Field type

- Fix the JSON Editor, is sending to the database the value non prettified

* - Fix issue adding a JSON column with log migration script enabled

When logging migration script the Convert layer is applied, and we didn't implement Convert for the JSON column

* IDEMPIERE-6227 Cannot add a column with spaces on the default value (Convert layer logging migration script)
2024-09-11 12:09:03 +02:00
hengsin 9f14c96134 IDEMPIERE-3040 Invoice Price Variations for Average PO costing method (#2428)
* IDEMPIERE-3040 Invoice Price Variations for Average PO costing method

Co-authored-by: dpansheriya <deepakpansheriya@gmail.com>
2024-09-11 12:01:07 +02:00
Carlos Ruiz 924bdb6fc1 IDEMPIERE-2981 Fixes to failing unit tests (#2263) 2024-06-17 23:53:21 +02:00
Diego Ruiz 5f44c9c19d IDEMPIERE-2981 - Implement JSON field type (#2255)
* IDEMPIERE-2981 - Implement JSON Field Type
* IDEMPIERE-2981 - Added field to the Test Window and Unit Tests
* IDEMPIERE-2981 - Fixed migration scripts
* IDEMPIERE-2981 - Changed oracle json syntax
* IDEMPIERE-2981 - Increased the number of lines of jsonData test field
* IDEMPIERE-2981 - Validate and Prettify JSON string on the field editor
* IDEMPIERE-2981 - Support for oracle
* IDEMPIERE-2981 - Applied patch from Carlos Ruiz
2024-06-17 23:53:01 +02:00
Carlos Ruiz a45283b855 IDEMPIERE-6165 + IDEMPIERE-6168 More problems with jasper setting filename (#2392)
- the test case is failing for orders with jasper print format
- the downloadable file name for jasper is wrong in zk when using FileNamePattern
2024-06-13 14:23:12 +02:00
Diego Ruiz 689573c90d IDEMPIERE-6165 - Custom name is not taken when running a core report … (#2386)
* IDEMPIERE-6165 - Custom name is not taken when running a core report programatically

* IDEMPIERE-6165 - Add unit test

* IDEMPIERE-6165 - Peer review changes

* IDEMPIERE-6165 - Modified condition to avoid potential NPE

* IDEMPIERE-6165 - Changed Unit Test to be thread safe

* IDEMPIERE-6165 - Create file in a thread-safe way respecting folder name if existing

* IDEMPIERE-6165 - Updated Unit test

* IDEMPIERE-6165 - Updated Unit test

* IDEMPIERE-6165 - Code refactor to remove code duplication in different classes

* IDEMPIERE-6165 - Improved Javadoc
2024-06-13 14:12:08 +02:00
hengsin 4875568cf2 IDEMPIERE-6117 POI: WorkbookFactory.create cannot be used to open XLSX files (#2357)
* IDEMPIERE-6117 POI: WorkbookFactory.create cannot be used to open XLSX files

* IDEMPIERE-6117 POI: WorkbookFactory.create cannot be used to open XLSX files

* IDEMPIERE-6117 POI: WorkbookFactory.create cannot be used to open XLSX files

- Incorporate patch from Carlos
2024-06-13 13:53:42 +02:00
hieplq 45544a2058 IDEMPIERE-6161:JasperReports encounters issues using encrypted functions due to incompatible dependencies (#2381)
* IDEMPIERE-6161:JasperReports encounters issues using encrypted functions due to incompatible dependencies

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
Co-authored-by: hengsin <hengsin@gmail.com>
2024-06-13 13:39:07 +02:00
Carlos Ruiz cad01851d5 IDEMPIERE-6159 Add drop ship location to ITaxLookup (#2380) 2024-06-13 13:37:24 +02:00
Carlos Ruiz 5d04cc7728 IDEMPIERE-6064 Error when creating a table with a long name through CreateTable process (#2290)
* IDEMPIERE-6064: Error when creating a table with a long time through CreateTable process

* IDEMPIERE-6064: Error when creating a table with a long name through CreateTable process

* - set the length of tablename to 60 char, and other database object names to 63

* - minor javadoc clarification

* - Increase size of other columns and process parameters

* - fix wrong value for Old MAX_OBJECT_NAME_LENGTH

---------

Co-authored-by: Nicolas Micoud <58596990+nmicoud@users.noreply.github.com>
2024-04-05 11:38:27 +02:00
hengsin af10c3a674 IDEMPIERE-5847 Wrong Posting in Shipment (#2280)
* IDEMPIERE-5847 Wrong Posting in Shipment

* IDEMPIERE-5847 Wrong Posting in Shipment

- minor unit test refinement

* IDEMPIERE-5847 Wrong Posting in Shipment

- Fix intermittent unit test error
2024-04-05 11:37:28 +02:00
hengsin 2f0baacfa0 IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has inconsistent +/- signs (#2273)
* IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has inconsistent +/- signs
* IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has inconsistent +/- signs
- use safer approach
2024-03-22 13:55:40 +01:00
Elaine Tan 2e76fbce5b IDEMPIERE-6025 Purchase Credit Memo > Create Lines From not displaying open/deferred matched PO invoice quantities (#2248)
* IDEMPIERE-6025 Purchase Credit Memo > Create Lines From not displaying open/deferred matched PO invoice quantities
2024-03-15 17:42:07 +01:00
hengsin b8947f1f06 IDEMPIERE-6043 Upgrade Jasper Report to version 6.21.0 (#2245) 2024-03-04 21:24:04 +01:00
Carlos Ruiz b46291d33a IDEMPIERE-6053 Problem with Convert_PostgreSQLTest running tests in parallel (#2253) 2024-03-04 21:21:38 +01:00
Carlos Ruiz 26bdfc276f IDEMPIERE-6036 Apply same approach to MLotCtl (#2237) 2024-03-04 21:17:30 +01:00
hengsin 6302f6f5fd IDEMPIERE-6029 Extract @SQL= and @SQLFIND= to constant (#2230) 2024-03-04 21:17:30 +01:00
hengsin 7224009efc IDEMPIERE-6032 MPInstanceLog ResultSet constructor not getting all value from result set (#2233) 2024-03-04 21:17:30 +01:00
hengsin c2111b9ccd IDEMPIERE-6036 Serial number control has potential to generate duplicate serial number under heavy load (#2236) 2024-03-04 21:17:30 +01:00
hengsin 61e3e48c9a IDEMPIERE-6035 Use saveCrossTenantSafe instead of PO.setCrossTenantSafe (#2235) 2024-03-04 21:17:03 +01:00
hieplq 815e363882 IDEMPIERE-6016:test case to simulate transaction timeouts and ensure no open connections remain afterwards (#2219)
* IDEMPIERE-6016:allow transaction monitor's scan timeout to a short duration

* IDEMPIERE-6016:test case to simulate transaction timeouts and ensure no open connections remain afterwards

* IDEMPIERE-6016:trx timeout make leak connection by call Connection.about but not call Connection.close(Hengsin review)

replace abort with rollback
use shorter duration for timeout test 2
add Isolatead and same thread execution class annotation

* IDEMPIERE-6016:trx timeout make leak connection by call Connection.about but not call Connection.close(Hengsin review)

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2024-03-04 21:13:19 +01:00
hengsin cdcf5d47f3 IDEMPIERE-6005 Unit Test: Display the test method to be executed in t… (#2217)
* IDEMPIERE-6005 Unit Test: Display the test method to be executed in the console

* IDEMPIERE-6005 Unit Test: Display the test method to be executed in the console

- Fix wrong configuration that run unit test twice
- added assembleRepository flag

* IDEMPIERE-6005 Unit Test: Display the test method to be executed in the console

- print classname.methodname() instead of just methodname()
2024-02-06 10:11:10 +01:00
hengsin 6c744c88da IDEMPIERE-6027 Alter column fail with PostgreSQL 16.1 (#2222) 2024-02-06 10:11:10 +01:00
luzpaz a87de727af IDEMPIERE-5838 Fix various typos (#2188)
* Fix various typos
Fixes user-facing and non-user-facing typos. Found via `codespell -q 3 -S "*.map,./migration,./migration-historic"`
* Added requested revisions
* Added requested revision
* Added requested revisions
2024-01-23 15:43:48 +01:00
Carlos Ruiz 17b012c376 IDEMPIERE-5567 - Parallel unit tests fail frequently with deadlock (#2190)
* IDEMPIERE-5567 - Parallel unit tests fail frequently with deadlock

when executing unit tests in parallel, MTestUUTest fails frequently with error detected deadlock
this can be caused by testReadingUpdatingTestUU trying to update translations and at the same time
the testDeletingTestUU is deleting the same record and deleting the same translations

* - implement suggestion from Heng Sin

* - remove unnecessary code
2024-01-23 15:43:48 +01:00
hieplq 0ea6a0352b IDEMPIERE-5980:spring-jcl make conflict between an export and import (slow down start idempiere on some condition) (#2175)
* IDEMPIERE-5980:spring-jcl make conflict between an export and import (slow down start idempiere on some condition)
2024-01-06 12:06:44 +01:00
Carlos Ruiz 3f912767a3
IDEMPIERE-5943 Implement table partitioning support (#2151)
* IDEMPIERE-5943 Implement table partitioning support

* - make it compatible with user preference Use Similar To
2023-12-21 06:41:11 +08:00
hengsin 7878721bf3
IDEMPIERE-5943 Implement table partitioning support (#2145)
* IDEMPIERE-5943 Implement table partitioning support

Co-authored-by: etantg <etan@trekglobal.com>
2023-12-20 14:10:04 +08:00
Elaine Tan d068b1977e
IDEMPIERE-5915 Generate Invoices (manual) > RMA => AR Credit Memo created with system date instead of "Date Invoiced" (#2097)
* IDEMPIERE-5915 Generate Invoices (manual) > RMA => AR Credit Memo created with system date instead of "Date Invoiced"

* IDEMPIERE-5915 Generate Invoices (manual) > RMA => AR Credit Memo created with system date instead of "Date Invoiced"
2023-11-09 13:14:38 +01:00
hengsin d58fb15f18
IDEMPIERE-5922 Jasper Report: support loading of jasper report file from non-fragment bundle (#2096) 2023-11-08 13:29:20 +01:00
hieplq ee66699d4a
IDEMPIERE-5909:use jdbc library as bundle (#2092)
* IDEMPIERE-5909:use jdbc library as bundle

* IDEMPIERE-5909:use jdbc library as bundle (version up)

* IDEMPIERE-5909:use jdbc library as bundle (update target id as CarlosRuiz suggest)
2023-11-08 12:12:35 +01:00
Carlos Ruiz 0c831cd9c8
IDEMPIERE-5063 Improve Unit Tests - Add jasper test (#2093)
* IDEMPIERE-5063 Improve Unit Tests - Add jasper test

* - add asserts as recommended by Heng Sin
- create temporary folder based on AD_Session_ID

* - rename method
2023-11-07 21:43:01 +08:00
hieplq d217eb531e
IDEMPIERE-5903 support multiple webservice project (#2084)
* IDEMPIERE-5903:support multi webservice project (issue 1:There is an endpoint already running on/rest)

https://stackoverflow.com/a/49553239/4037367

* IDEMPIERE-5903:support multi webservice project (reuse resource)

* IDEMPIERE-5903:support multi webservice project (fix comment review)
2023-11-04 20:09:27 +08:00
Elaine Tan a061eeedb4
IDEMPIERE-5878 Wrong GL posting in allocation for payment REVERSE/ACCRUAL, if payment WITH charge (#2074) 2023-10-25 16:01:29 +08:00
Carlos Ruiz ef9ecb3490
IDEMPIERE-4639 simplify calls using saveCrossTenantSafeEx when possible (#2073)
* IDEMPIERE-4639 simplify calls using saveCrossTenantSafeEx when possible

* - integrate patch from Heng Sin
2023-10-22 21:23:23 +08:00
Carlos Ruiz bb3856dbb0
IDEMPIERE-5793 premature dunning when dunning run is done on exactly the due date (#2064)
* IDEMPIERE-5793 premature dunning when dunning run is done on exactly the due date

* - fix unit test
2023-10-18 14:44:43 +08:00
Deepak Pansheriya cb6c8b636d
IDEMPIERE-5836: Adding unit test cases for Non stocked expense curren… (#2024)
* IDEMPIERE-5836: Adding unit test cases for Non stocked expense current bhavior

* IDEMPIERE-5836: Refactoring as per code review comments.

* IDEMPIERE-5836: Corrected code comments as per peer review
2023-09-29 22:54:23 +08:00
Carlos Ruiz 7c8fe24435
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - AD_PInstance (#2003)
- Implement support to run processes on UUID based tables
- Added SvrProcess.getRecord_UU and getRecord_UUs support
- Added TestUUChangeActive process as toolbar button on "Test UU Based Table" window - supports single and multi
- Added AD_PInstance.AD_Table_ID and AD_PInstance.Record_UU
- NOTE: the migration script tries the best to fill AD_PInstance.AD_Table_ID from different sources, but at the end is very possible that some records will be left with empty table
- The MPInstance constructors that don't manage AD_Table_ID were marked as deprecated to ease discovering the missing parts in plugins
2023-09-13 10:59:21 +08:00
Deepak Pansheriya 18f925fd2f
IDEMPIERE-5768 : Adding Credit manager factory to override or extend … (#1949)
* IDEMPIERE-5768 : Adding Credit manager factory to override or extend credit management

* IDEMPIERE-5768 : Fixing as as per code review comments from Hengsin

* IDEMPIERE-5768: Use component annotation instead of xml service definition

* IDEMPIERE-5768: Adding Unit tests and Making return type of CheckCreditStatus to be object instead of String.

* IDEMPIERE-5768: Fixing as per code review comment.

* IDEMPIERE-5768: Removed explicit rollback from test cases
2023-08-23 09:39:24 +08:00
hengsin e46d57e1ea
IDEMPIERE-5812 Reversal of Material Receipt for a Closed PO leave quantity ordered of product in a bad state (#1964) 2023-08-08 14:02:28 +02:00
Carlos Ruiz 472032fa44
IDEMPIERE-5821 Credit Memos are commissioning positive (#1965) 2023-08-04 14:41:30 +08:00
Carlos Ruiz 159fbbd04c
IDEMPIERE-5732 Cache reset should happens after commit of transaction (#1850)
* IDEMPIERE-5732 Cache reset should happens after commit of transaction

* IDEMPIERE-5732 Cache reset should happens after commit of transaction

* - minor defensive programming

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-08-01 19:53:11 +08:00
hengsin 890862de47
IDEMPIERE-4416 invalidating a purchase order doesn't remove connectio… (#1942)
* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- refactoring, make MiniTableImpl usable outside of test

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- refactoring, move business and sql logic from Match to model class.
- add more unit test

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- set M_InOut.C_Order_ID to null

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- update unit test for setting of M_InOut.C_Order_ID to null.
2023-07-31 15:20:26 +02:00
Elaine Tan eed078308c
IDEMPIERE-5757 immediate post: Payment REVERSE/CORRECT allocation document NOT posted (#1922)
* IDEMPIERE-5757 immediate post: Payment REVERSE/CORRECT allocation document NOT posted
2023-07-10 21:38:31 +08:00
Nicolas Micoud b28735509d
IDEMPIERE-5794: New param for getBusinessDaysBetween to include/exlud… (#1928)
* IDEMPIERE-5794: New param for getBusinessDaysBetween to include/exlude end date

https://idempiere.atlassian.net/browse/IDEMPIERE-5794

* IDEMPIERE-5794: New param for getBusinessDaysBetween to include/exlude end date - Unit tests

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

---------

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2023-07-10 14:41:39 +08:00
Carlos Ruiz b7c089fc1d
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Implement support for Requests on UUID Based Tables (#1910)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Implement support for Requests on UUID Based Tables

* - minor typo

* - improve javadoc
2023-07-08 12:09:56 +08:00
Elaine Tan fce4d5cf9c
IDEMPIERE-5591 Payment allocation AP/AR GL postings not zero in alternative schema for invoice REVERSE/CORRECT (#1921) 2023-07-08 11:37:17 +08:00
Carlos Ruiz 7adbc91505
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Archive (#1895)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Archive

* - Support for master/detail reports on UUID based tables

* - Archive button

* - Add test print format for UU Based Table

* - backward compatibility on MArchive.getReportAndDocumentCountByRecordId

* - Backward compatibility with filesystem storage

* - Improve naming of temporary folder for 2Pack

* - Improve query to use correctly the index

* - Improve method to use ID when no UUID

* - Ensure the Record_UU is filled even when called from foreign sources

* - Implement the same provision for exceptional cases on MAttachment, MChat, MLabelAssignment, MPostIt to fill the UUID when not passed (f.e. when created by a plugin)
2023-06-23 11:17:51 +08:00
Carlos Ruiz 3641e398ca
IDEMPIERE-5776 Cannot generate shipment for an order with multiple lines for same product and Complete Order delivery rule (#1900) 2023-06-22 14:00:27 +08:00