From fb189f010c3ac6b5fb21c6fcb94dd4b6d21ba3ac Mon Sep 17 00:00:00 2001
From: Carlos Ruiz <carg67@gmail.com>
Date: Sat, 26 Mar 2011 00:36:07 -0500
Subject: [PATCH] Fix problem with [3007342] - Included tab context conflict
 issue
 https://sourceforge.net/tracker/index.php?func=detail&aid=3007342&group_id=176962&atid=879332
 This functionality must preserve the value of the parent tab JUST when is an
 included tab not included tabs can have Processed fields and is valid to add
 records in details on these cases like the Payment Schedule tab on Invoice
 (Customer) window

---
 .../src/org/compiere/model/GridField.java     |  5 +++++
 .../src/org/compiere/model/GridTab.java       | 21 ++++++++++++++++---
 2 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/org.adempiere.base/src/org/compiere/model/GridField.java b/org.adempiere.base/src/org/compiere/model/GridField.java
index 67a208efff..11d702b255 100644
--- a/org.adempiere.base/src/org/compiere/model/GridField.java
+++ b/org.adempiere.base/src/org/compiere/model/GridField.java
@@ -1872,6 +1872,11 @@ public class GridField
 	{
 		if (m_gridTab == null)
 			return false;
+		// this functionality must preserve the value of the parent tab JUST when is an included tab
+		// not included tabs can have Processed fields and is valid to add records in details on these cases
+		// like the Payment Schedule tab on Invoice (Customer) window
+		if (!m_gridTab.isIncluded())
+			return false;
 		GridTab parentTab = m_gridTab.getParentTab();
 		if (parentTab == null)
 			return false;
diff --git a/org.adempiere.base/src/org/compiere/model/GridTab.java b/org.adempiere.base/src/org/compiere/model/GridTab.java
index ed75490b89..d9eb6a9b5b 100644
--- a/org.adempiere.base/src/org/compiere/model/GridTab.java
+++ b/org.adempiere.base/src/org/compiere/model/GridTab.java
@@ -107,7 +107,7 @@ public class GridTab implements DataStatusListener, Evaluatee, Serializable
 	/**
 	 *
 	 */
-	private static final long serialVersionUID = -8055500064230704903L;
+	private static final long serialVersionUID = -3825605601192688998L;
 
 	public static final String DEFAULT_STATUS_MESSAGE = "NavigateOrUpdate";
 
@@ -196,7 +196,8 @@ public class GridTab implements DataStatusListener, Evaluatee, Serializable
 	private volatile boolean    m_loadComplete = false;
 	/** Is Tab Included in other Tab  */
 	private boolean    			m_included = false;
-
+	private boolean    			m_includedAlreadyCalc = false;
+	
 	/**	Logger			*/
 	protected CLogger	log = CLogger.getCLogger(getClass());
 
@@ -1349,13 +1350,26 @@ public class GridTab implements DataStatusListener, Evaluatee, Serializable
 	 */
 	public boolean isIncluded()
 	{
+		if (! m_includedAlreadyCalc) {
+			m_included = false;
+			if (getParentTab() != null) {
+				for (GridTab tab : getParentTab().getIncludedTabs()) {
+					if (tab.equals(this)) {
+						m_included = true;
+						break;
+					}
+				}
+			}
+			m_includedAlreadyCalc = true;
+		}		
 		return m_included;
 	}   //  isIncluded
 
 	/**
 	 *  Is Tab Included in other Tab
 	 *  @param isIncluded true if included
-	 */
+	 *  @deprecated The method getIncluded now validate against the structure, this method is called nowhere
+	*/
 	public void setIncluded(boolean isIncluded)
 	{
 		m_included = isIncluded;
@@ -1603,6 +1617,7 @@ public class GridTab implements DataStatusListener, Evaluatee, Serializable
 	/**
 	 *	Get Included Tab ID
 	 *  @return Included_Tab_ID
+	 *  @deprecated the functionality related to AD_Tab.Included_Tab_ID was not developed
 	 */
 	public int getIncluded_Tab_ID()
 	{