From c61ce5d86d43e187f3056bad3c23bfc75181cab0 Mon Sep 17 00:00:00 2001
From: "Redhuan D. Oon" <red1@red1.org>
Date: Fri, 5 Mar 2010 14:49:46 +0000
Subject: [PATCH] FR: [ 2214883 ] Remove SQL code and Replace for Query  --
 JUnit test pending Link to SF Tracker:
 http://sourceforge.net/support/tracker.php?aid=2214883

---
 .../org/compiere/model/MBankStatement.java    | 37 +++----------------
 1 file changed, 6 insertions(+), 31 deletions(-)

diff --git a/base/src/org/compiere/model/MBankStatement.java b/base/src/org/compiere/model/MBankStatement.java
index 46e7870eee..8e07360cd4 100644
--- a/base/src/org/compiere/model/MBankStatement.java
+++ b/base/src/org/compiere/model/MBankStatement.java
@@ -22,6 +22,7 @@ import java.sql.PreparedStatement;
 import java.sql.ResultSet;
 import java.sql.Timestamp;
 import java.util.ArrayList;
+import java.util.List;
 import java.util.Properties;
 import java.util.logging.Level;
 
@@ -131,37 +132,11 @@ public class MBankStatement extends X_C_BankStatement implements DocAction
 			return m_lines;
 		}
 		//
- 		ArrayList<MBankStatementLine> list = new ArrayList<MBankStatementLine>();
- 		String sql = "SELECT * FROM C_BankStatementLine "
- 			+ "WHERE C_BankStatement_ID=?"
- 			+ "ORDER BY Line";
- 		PreparedStatement pstmt = null;
-		try
-		{
-			pstmt = DB.prepareStatement(sql, get_TrxName());
-			pstmt.setInt(1, getC_BankStatement_ID());
-			ResultSet rs = pstmt.executeQuery();
-			while (rs.next())
-				list.add (new MBankStatementLine(getCtx(), rs, get_TrxName()));
-			rs.close();
-			pstmt.close();
-			pstmt = null;
-		}
-		catch (Exception e)
-		{
-			log.log(Level.SEVERE, "getLines", e);
-		}
-		try
-		{
-			if (pstmt != null)
-				pstmt.close();
-			pstmt = null;
-		}
-		catch (Exception e)
-		{
-			pstmt = null;
-		}
- 		
+		final String whereClause = I_C_BankStatementLine.COLUMNNAME_C_BankStatement_ID+"=?";
+		List<MBankStatementLine> list = new Query(getCtx(),I_C_BankStatementLine.Table_Name,whereClause,get_TrxName())
+		.setParameters(getC_BankStatement_ID())
+		.setOrderBy("Line")
+		.list();
 		MBankStatementLine[] retValue = new MBankStatementLine[list.size()];
 		list.toArray(retValue);
 		return retValue;