Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Heng Sin's advice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
This commit is contained in:
parent
d0fcc6068a
commit
998d5c20f5
|
|
@ -181,7 +181,7 @@ public final class MAccountLookup extends Lookup implements Serializable
|
||||||
String whereClause = "AD_Client_ID=?";
|
String whereClause = "AD_Client_ID=?";
|
||||||
params.add(Env.getAD_Client_ID(m_ctx));
|
params.add(Env.getAD_Client_ID(m_ctx));
|
||||||
|
|
||||||
List<MAccount> accounts = new Query(Env.getCtx(),MAccount.Table_Name,whereClause,null)
|
List<MAccount> accounts = new Query(Env.getCtx(),I_C_ValidCombination.Table_Name,whereClause,null)
|
||||||
.setParameters(params)
|
.setParameters(params)
|
||||||
.setOrderBy(MAccount.COLUMNNAME_Combination)
|
.setOrderBy(MAccount.COLUMNNAME_Combination)
|
||||||
.setOnlyActiveRecords(onlyActive)
|
.setOnlyActiveRecords(onlyActive)
|
||||||
|
|
|
||||||
|
|
@ -49,7 +49,7 @@ public class MAcctProcessor extends X_C_AcctProcessor
|
||||||
*/
|
*/
|
||||||
public static MAcctProcessor[] getActive (Properties ctx)
|
public static MAcctProcessor[] getActive (Properties ctx)
|
||||||
{
|
{
|
||||||
List<MAcctProcessor> list = new Query(ctx, MAcctProcessor.Table_Name, null, null)
|
List<MAcctProcessor> list = new Query(ctx, I_C_AcctProcessor.Table_Name, null, null)
|
||||||
.setOnlyActiveRecords(true)
|
.setOnlyActiveRecords(true)
|
||||||
.list();
|
.list();
|
||||||
return list.toArray(new MAcctProcessor[list.size()]);
|
return list.toArray(new MAcctProcessor[list.size()]);
|
||||||
|
|
@ -129,8 +129,8 @@ public class MAcctProcessor extends X_C_AcctProcessor
|
||||||
public AdempiereProcessorLog[] getLogs ()
|
public AdempiereProcessorLog[] getLogs ()
|
||||||
{
|
{
|
||||||
String whereClause = "C_AcctProcessor_ID=? ";
|
String whereClause = "C_AcctProcessor_ID=? ";
|
||||||
List<MAcctProcessor> list = new Query(getCtx(), MAcctProcessorLog.Table_Name,whereClause,get_TrxName())
|
List<MAcctProcessor> list = new Query(getCtx(), I_C_AcctProcessorLog.Table_Name,whereClause,get_TrxName())
|
||||||
.setParameters(new Object[]{getC_AcctProcessor_ID()})
|
.setParameters(getC_AcctProcessor_ID())
|
||||||
.setOrderBy("Created DESC")
|
.setOrderBy("Created DESC")
|
||||||
.list();
|
.list();
|
||||||
return list.toArray(new MAcctProcessorLog[list.size()]);
|
return list.toArray(new MAcctProcessorLog[list.size()]);
|
||||||
|
|
|
||||||
|
|
@ -115,7 +115,7 @@ public class MAcctSchema extends X_C_AcctSchema
|
||||||
params.add(AD_Client_ID);
|
params.add(AD_Client_ID);
|
||||||
}
|
}
|
||||||
|
|
||||||
List <MAcctSchema> ass = new Query(ctx, MAcctSchema.Table_Name,whereClause,trxName)
|
List <MAcctSchema> ass = new Query(ctx, I_C_AcctSchema.Table_Name,whereClause,trxName)
|
||||||
.setParameters(params)
|
.setParameters(params)
|
||||||
.setOrderBy(MAcctSchema.COLUMNNAME_C_AcctSchema_ID)
|
.setOrderBy(MAcctSchema.COLUMNNAME_C_AcctSchema_ID)
|
||||||
.list();
|
.list();
|
||||||
|
|
|
||||||
|
|
@ -47,8 +47,8 @@ public class MAcctSchemaDefault extends X_C_AcctSchema_Default
|
||||||
public static MAcctSchemaDefault get (Properties ctx, int C_AcctSchema_ID)
|
public static MAcctSchemaDefault get (Properties ctx, int C_AcctSchema_ID)
|
||||||
{
|
{
|
||||||
String whereClause = "C_AcctSchema_ID=?";
|
String whereClause = "C_AcctSchema_ID=?";
|
||||||
return new Query(ctx,MAcctSchemaDefault.Table_Name,whereClause,null)
|
return new Query(ctx,I_C_AcctSchema_Default.Table_Name,whereClause,null)
|
||||||
.setParameters(new Object[]{C_AcctSchema_ID})
|
.setParameters(C_AcctSchema_ID)
|
||||||
.firstOnly();
|
.firstOnly();
|
||||||
} // get
|
} // get
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -62,8 +62,9 @@ public final class MAcctSchemaElement extends X_C_AcctSchema_Element
|
||||||
ArrayList<MAcctSchemaElement> list = new ArrayList<MAcctSchemaElement>();
|
ArrayList<MAcctSchemaElement> list = new ArrayList<MAcctSchemaElement>();
|
||||||
|
|
||||||
String whereClause = "C_AcctSchema_ID=? AND IsActive=?";
|
String whereClause = "C_AcctSchema_ID=? AND IsActive=?";
|
||||||
List<MAcctSchemaElement> elements= new Query(as.getCtx(), MAcctSchemaElement.Table_Name,whereClause,as.get_TrxName())
|
List<MAcctSchemaElement> elements= new Query(as.getCtx(), I_C_AcctSchema_Element.Table_Name,whereClause,as.get_TrxName())
|
||||||
.setParameters(new Object[]{as.getC_AcctSchema_ID(),"Y"}).setOrderBy("SeqNo")
|
.setParameters(as.getC_AcctSchema_ID(),"Y")
|
||||||
|
.setOrderBy("SeqNo")
|
||||||
.list();
|
.list();
|
||||||
|
|
||||||
for(MAcctSchemaElement ase : elements)
|
for(MAcctSchemaElement ase : elements)
|
||||||
|
|
|
||||||
|
|
@ -50,8 +50,8 @@ public class MAcctSchemaGL extends X_C_AcctSchema_GL
|
||||||
public static MAcctSchemaGL get (Properties ctx, int C_AcctSchema_ID)
|
public static MAcctSchemaGL get (Properties ctx, int C_AcctSchema_ID)
|
||||||
{
|
{
|
||||||
String whereClause = "C_AcctSchema_ID=?";
|
String whereClause = "C_AcctSchema_ID=?";
|
||||||
return new Query(ctx,MAcctSchemaGL.Table_Name,whereClause,null)
|
return new Query(ctx,I_C_AcctSchema_GL.Table_Name,whereClause,null)
|
||||||
.setParameters(new Object[]{C_AcctSchema_ID})
|
.setParameters(C_AcctSchema_ID)
|
||||||
.firstOnly();
|
.firstOnly();
|
||||||
} // get
|
} // get
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -110,7 +110,7 @@ public class M_Element extends X_AD_Element
|
||||||
String whereClause = "EXISTS (SELECT 1 FROM AD_Column c "
|
String whereClause = "EXISTS (SELECT 1 FROM AD_Column c "
|
||||||
+ "WHERE c.AD_Element_ID=AD_Element.AD_Element_ID AND c.AD_Column_ID=?)";
|
+ "WHERE c.AD_Element_ID=AD_Element.AD_Element_ID AND c.AD_Column_ID=?)";
|
||||||
M_Element retValue = new Query(ctx, Table_Name, whereClause, trxName)
|
M_Element retValue = new Query(ctx, Table_Name, whereClause, trxName)
|
||||||
.setParameters(new Object[]{AD_Column_ID})
|
.setParameters(AD_Column_ID)
|
||||||
.firstOnly();
|
.firstOnly();
|
||||||
return retValue;
|
return retValue;
|
||||||
} // get
|
} // get
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue