From 9227c53c4f5687a94917e2c94f4693984f0d8301 Mon Sep 17 00:00:00 2001 From: teo_sarca Date: Tue, 13 Jan 2009 12:45:56 +0000 Subject: [PATCH] Libero QA: PP_Order_Transactions view : never use ORDER BY clause in a view; it's a bad practice --- db/ddlutils/oracle/views/RV_PP_ORDER_TRANSACTIONS.sql | 6 +----- db/ddlutils/postgresql/views/RV_PP_ORDER_TRANSACTIONS.sql | 6 +----- migration/353a-trunk/oracle/392_FR_ShowCostCollectior.sql | 6 +----- .../353a-trunk/postgresql/392_FR_ShowCostCollectior.sql | 6 +----- 4 files changed, 4 insertions(+), 20 deletions(-) diff --git a/db/ddlutils/oracle/views/RV_PP_ORDER_TRANSACTIONS.sql b/db/ddlutils/oracle/views/RV_PP_ORDER_TRANSACTIONS.sql index 1ea167cd73..d2f36641b7 100644 --- a/db/ddlutils/oracle/views/RV_PP_ORDER_TRANSACTIONS.sql +++ b/db/ddlutils/oracle/views/RV_PP_ORDER_TRANSACTIONS.sql @@ -29,8 +29,4 @@ FROM pp_order o JOIN pp_order_bomline ol ON ol.pp_order_id = o.pp_order_id JOIN pp_cost_collector cc ON cc.pp_order_bomline_id = ol.pp_order_bomline_id LEFT JOIN m_transaction mt ON mt.pp_cost_collector_id = cc.pp_cost_collector_id -ORDER BY -o.ad_client_id, o.ad_org_id, o.isactive, o.created, o.createdby, o.updatedby, o.updated, o.documentno, ol.m_product_id, mt.m_locator_id, mt.movementdate, o.pp_order_id, o.qtydelivered, o.qtyscrap, ol.qtydelivered, o.qtydelivered * ol.qtybatch / 100, ol.qtyscrap, o.qtyscrap * ol.qtybatch / 100, mt.createdby, mt.updatedby, -(SELECT sum(t.movementqty) AS sum FROM m_transaction t WHERE t.pp_cost_collector_id = cc.pp_cost_collector_id), (o.qtydelivered + o.qtyscrap) * ol.qtybatch / 100 + (( SELECT sum(t.movementqty) AS sum FROM m_transaction t WHERE t.pp_cost_collector_id = cc.pp_cost_collector_id)), -o.issotrx, -o.dateordered; +; diff --git a/db/ddlutils/postgresql/views/RV_PP_ORDER_TRANSACTIONS.sql b/db/ddlutils/postgresql/views/RV_PP_ORDER_TRANSACTIONS.sql index 1ea167cd73..d2f36641b7 100644 --- a/db/ddlutils/postgresql/views/RV_PP_ORDER_TRANSACTIONS.sql +++ b/db/ddlutils/postgresql/views/RV_PP_ORDER_TRANSACTIONS.sql @@ -29,8 +29,4 @@ FROM pp_order o JOIN pp_order_bomline ol ON ol.pp_order_id = o.pp_order_id JOIN pp_cost_collector cc ON cc.pp_order_bomline_id = ol.pp_order_bomline_id LEFT JOIN m_transaction mt ON mt.pp_cost_collector_id = cc.pp_cost_collector_id -ORDER BY -o.ad_client_id, o.ad_org_id, o.isactive, o.created, o.createdby, o.updatedby, o.updated, o.documentno, ol.m_product_id, mt.m_locator_id, mt.movementdate, o.pp_order_id, o.qtydelivered, o.qtyscrap, ol.qtydelivered, o.qtydelivered * ol.qtybatch / 100, ol.qtyscrap, o.qtyscrap * ol.qtybatch / 100, mt.createdby, mt.updatedby, -(SELECT sum(t.movementqty) AS sum FROM m_transaction t WHERE t.pp_cost_collector_id = cc.pp_cost_collector_id), (o.qtydelivered + o.qtyscrap) * ol.qtybatch / 100 + (( SELECT sum(t.movementqty) AS sum FROM m_transaction t WHERE t.pp_cost_collector_id = cc.pp_cost_collector_id)), -o.issotrx, -o.dateordered; +; diff --git a/migration/353a-trunk/oracle/392_FR_ShowCostCollectior.sql b/migration/353a-trunk/oracle/392_FR_ShowCostCollectior.sql index 7a99020d5e..a989c2c78f 100644 --- a/migration/353a-trunk/oracle/392_FR_ShowCostCollectior.sql +++ b/migration/353a-trunk/oracle/392_FR_ShowCostCollectior.sql @@ -93,11 +93,7 @@ FROM pp_order o JOIN pp_order_bomline ol ON ol.pp_order_id = o.pp_order_id JOIN pp_cost_collector cc ON cc.pp_order_bomline_id = ol.pp_order_bomline_id LEFT JOIN m_transaction mt ON mt.pp_cost_collector_id = cc.pp_cost_collector_id -ORDER BY -o.ad_client_id, o.ad_org_id, o.isactive, o.created, o.createdby, o.updatedby, o.updated, o.documentno, ol.m_product_id, mt.m_locator_id, mt.movementdate, o.pp_order_id, o.qtydelivered, o.qtyscrap, ol.qtydelivered, o.qtydelivered * ol.qtybatch / 100, ol.qtyscrap, o.qtyscrap * ol.qtybatch / 100, mt.createdby, mt.updatedby, -(SELECT sum(t.movementqty) AS sum FROM m_transaction t WHERE t.pp_cost_collector_id = cc.pp_cost_collector_id), (o.qtydelivered + o.qtyscrap) * ol.qtybatch / 100 + (( SELECT sum(t.movementqty) AS sum FROM m_transaction t WHERE t.pp_cost_collector_id = cc.pp_cost_collector_id)), -o.issotrx, -o.dateordered; +; ALTER TABLE m_transaction DROP COLUMN pp_order_id; ALTER TABLE m_transaction DROP COLUMN pp_order_bomline_id; \ No newline at end of file diff --git a/migration/353a-trunk/postgresql/392_FR_ShowCostCollectior.sql b/migration/353a-trunk/postgresql/392_FR_ShowCostCollectior.sql index 52c06a7ca2..2b7b867aa6 100644 --- a/migration/353a-trunk/postgresql/392_FR_ShowCostCollectior.sql +++ b/migration/353a-trunk/postgresql/392_FR_ShowCostCollectior.sql @@ -96,11 +96,7 @@ FROM pp_order o JOIN pp_order_bomline ol ON ol.pp_order_id = o.pp_order_id JOIN pp_cost_collector cc ON cc.pp_order_bomline_id = ol.pp_order_bomline_id LEFT JOIN m_transaction mt ON mt.pp_cost_collector_id = cc.pp_cost_collector_id -ORDER BY -o.ad_client_id, o.ad_org_id, o.isactive, o.created, o.createdby, o.updatedby, o.updated, o.documentno, ol.m_product_id, mt.m_locator_id, mt.movementdate, o.pp_order_id, o.qtydelivered, o.qtyscrap, ol.qtydelivered, o.qtydelivered * ol.qtybatch / 100, ol.qtyscrap, o.qtyscrap * ol.qtybatch / 100, mt.createdby, mt.updatedby, -(SELECT sum(t.movementqty) AS sum FROM m_transaction t WHERE t.pp_cost_collector_id = cc.pp_cost_collector_id), (o.qtydelivered + o.qtyscrap) * ol.qtybatch / 100 + (( SELECT sum(t.movementqty) AS sum FROM m_transaction t WHERE t.pp_cost_collector_id = cc.pp_cost_collector_id)), -o.issotrx, -o.dateordered; +; ALTER TABLE m_transaction DROP COLUMN pp_order_id; ALTER TABLE m_transaction DROP COLUMN pp_order_bomline_id; \ No newline at end of file