midsuit
/
core-jgi
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-2555 Fact Reconciliation statement leak

This commit is contained in:
Carlos Ruiz 2015-04-01 09:40:13 -05:00
parent 2dfefe0ecd
commit 7b07b58314
1 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
org.adempiere.base/src/org/compiere/process/FactReconcile.java
View File

@ -17,7 +17,6 @@
package org.compiere.process; package org.compiere.process;
import java.sql.PreparedStatement; import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException; import java.sql.SQLException;
import java.util.logging.Level; import java.util.logging.Level;
@ -118,7 +117,6 @@ public class FactReconcile extends SvrProcess
if (log.isLoggable(Level.INFO)) log.info("AD_PInstance_ID= " + getAD_PInstance_ID()); if (log.isLoggable(Level.INFO)) log.info("AD_PInstance_ID= " + getAD_PInstance_ID());
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
int count; int count;
int unmatched; int unmatched;
@ -126,8 +124,8 @@ public class FactReconcile extends SvrProcess
if (seq == null) if (seq == null)
throw new AdempiereException("No sequence for Fact_Reconciliation table"); throw new AdempiereException("No sequence for Fact_Reconciliation table");
try try
{ {
// add new facts into reconciliation table // add new facts into reconciliation table
sql = "INSERT into Fact_Reconciliation " + sql = "INSERT into Fact_Reconciliation " +
"(Fact_Reconciliation_ID, AD_Client_ID, AD_Org_ID, Created, CreatedBy, Updated, UpdatedBy, " + "(Fact_Reconciliation_ID, AD_Client_ID, AD_Org_ID, Created, CreatedBy, Updated, UpdatedBy, " +
@ -144,6 +142,7 @@ public class FactReconcile extends SvrProcess
pstmt.setInt(1, seq.getAD_Sequence_ID()); pstmt.setInt(1, seq.getAD_Sequence_ID());
pstmt.setInt(2, account.get_ID()); pstmt.setInt(2, account.get_ID());
count = pstmt.executeUpdate(); count = pstmt.executeUpdate();
DB.close(pstmt); pstmt = null;
if (log.isLoggable(Level.FINE))log.log(Level.FINE, "Inserted " + count + " new facts into Fact_Reconciliation"); if (log.isLoggable(Level.FINE))log.log(Level.FINE, "Inserted " + count + " new facts into Fact_Reconciliation");
// set the matchcode based on the rule found in AD_Rule // set the matchcode based on the rule found in AD_Rule
@ -160,6 +159,7 @@ public class FactReconcile extends SvrProcess
pstmt = DB.prepareStatement(sql, get_TrxName()); pstmt = DB.prepareStatement(sql, get_TrxName());
pstmt.setInt(1, account.get_ID()); pstmt.setInt(1, account.get_ID());
count = pstmt.executeUpdate(); count = pstmt.executeUpdate();
DB.close(pstmt); pstmt = null;
if (log.isLoggable(Level.FINE))log.log(Level.FINE, "Updated " + count + " match codes."); if (log.isLoggable(Level.FINE))log.log(Level.FINE, "Updated " + count + " match codes.");
@ -180,18 +180,17 @@ public class FactReconcile extends SvrProcess
unmatched = pstmt.executeUpdate(); unmatched = pstmt.executeUpdate();
if (log.isLoggable(Level.FINE))log.log(Level.FINE, "Cleared match codes from " + unmatched + " unreconciled facts."); if (log.isLoggable(Level.FINE))log.log(Level.FINE, "Cleared match codes from " + unmatched + " unreconciled facts.");
}
} catch (SQLException e)
catch (SQLException e) {
{
log.log(Level.SEVERE, sql, e); log.log(Level.SEVERE, sql, e);
return e.getLocalizedMessage(); return e.getLocalizedMessage();
} }
finally finally
{ {
DB.close(rs, pstmt); DB.close(pstmt);
rs = null; pstmt = null; pstmt = null;
} }
return "Matched " + (count-unmatched) + " facts"; return "Matched " + (count-unmatched) + " facts";
} // doIt } // doIt