midsuit
/
core-jgi
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BF [ 1874419 ] JDBC Statement not close in a finally block - fixed for org.compiere.model.MMeasure

This commit is contained in:
teo_sarca 2008-02-06 08:02:35 +00:00
parent 2cd9802c0f
commit 71bd400ba9
1 changed files with 5 additions and 80 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

85
base/src/org/compiere/model/MMeasure.java
View File

@ -265,34 +265,9 @@ public class MMeasure extends X_PA_Measure
log.log(Level.SEVERE, "Not found PA_MeasureCalc_ID=" + getPA_MeasureCalc_ID()); log.log(Level.SEVERE, "Not found PA_MeasureCalc_ID=" + getPA_MeasureCalc_ID());
return false; return false;
} }
BigDecimal ManualActual = null;
String sql = mc.getSqlPI(goal.getRestrictions(false), String sql = mc.getSqlPI(goal.getRestrictions(false),
goal.getMeasureScope(), getMeasureDataType(), null, role); goal.getMeasureScope(), getMeasureDataType(), null, role);
PreparedStatement pstmt = null; BigDecimal ManualActual = DB.getSQLValueBD(null, sql, new Object[]{});
try // SQL statement could be wrong
{
pstmt = DB.prepareStatement (sql, null);
ResultSet rs = pstmt.executeQuery();
if (rs.next())
ManualActual = rs.getBigDecimal(1);
rs.close ();
pstmt.close ();
pstmt = null;
}
catch (Exception e)
{
log.log (Level.SEVERE, sql, e);
}
try
{
if (pstmt != null)
pstmt.close ();
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
}
// SQL may return no rows or null // SQL may return no rows or null
if (ManualActual == null) if (ManualActual == null)
{ {
@ -343,35 +318,10 @@ public class MMeasure extends X_PA_Measure
if (role == null) if (role == null)
role = MRole.getDefault(getCtx(), false); // could result in wrong data role = MRole.getDefault(getCtx(), false); // could result in wrong data
// //
BigDecimal ManualActual = null;
MRequestType rt = MRequestType.get(getCtx(), getR_RequestType_ID()); MRequestType rt = MRequestType.get(getCtx(), getR_RequestType_ID());
String sql = rt.getSqlPI(goal.getRestrictions(false), String sql = rt.getSqlPI(goal.getRestrictions(false),
goal.getMeasureScope(), getMeasureDataType(), null, role); goal.getMeasureScope(), getMeasureDataType(), null, role);
PreparedStatement pstmt = null; BigDecimal ManualActual = DB.getSQLValueBD(null, sql, new Object[]{});
try // SQL statement could be wrong
{
pstmt = DB.prepareStatement (sql, null);
ResultSet rs = pstmt.executeQuery();
if (rs.next())
ManualActual = rs.getBigDecimal(1);
rs.close ();
pstmt.close ();
pstmt = null;
}
catch (Exception e)
{
log.log (Level.SEVERE, sql, e);
}
try
{
if (pstmt != null)
pstmt.close ();
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
}
// SQL may return no rows or null // SQL may return no rows or null
if (ManualActual == null) if (ManualActual == null)
{ {
@ -411,35 +361,10 @@ public class MMeasure extends X_PA_Measure
if (role == null) if (role == null)
role = MRole.getDefault(getCtx(), false); // could result in wrong data role = MRole.getDefault(getCtx(), false); // could result in wrong data
// //
BigDecimal ManualActual = null;
MProjectType pt = MProjectType.get(getCtx(), getC_ProjectType_ID()); MProjectType pt = MProjectType.get(getCtx(), getC_ProjectType_ID());
String sql = pt.getSqlPI(goal.getRestrictions(false), String sql = pt.getSqlPI(goal.getRestrictions(false),
goal.getMeasureScope(), getMeasureDataType(), null, role); goal.getMeasureScope(), getMeasureDataType(), null, role);
PreparedStatement pstmt = null; BigDecimal ManualActual = DB.getSQLValueBD(null, sql, new Object[]{});
try // SQL statement could be wrong
{
pstmt = DB.prepareStatement (sql, null);
ResultSet rs = pstmt.executeQuery();
if (rs.next())
ManualActual = rs.getBigDecimal(1);
rs.close ();
pstmt.close ();
pstmt = null;
}
catch (Exception e)
{
log.log (Level.SEVERE, sql, e);
}
try
{
if (pstmt != null)
pstmt.close ();
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
}
// SQL may return no rows or null // SQL may return no rows or null
if (ManualActual == null) if (ManualActual == null)
{ {