midsuit
/
core-jgi
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BF[2779278] Document Action Access bug

This commit is contained in:
Heng Sin Low 2009-04-23 07:42:16 +00:00
parent 4bbd214d51
commit 6050c6a05f
1 changed files with 67 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

122
zkwebui/WEB-INF/src/org/adempiere/webui/panel/WDocActionPanel.java
View File

@ -48,54 +48,54 @@ import org.zkoss.zul.Space;
public class WDocActionPanel extends Window implements EventListener public class WDocActionPanel extends Window implements EventListener
{ {
/** /**
* *
*/ */
private static final long serialVersionUID = 1L; private static final long serialVersionUID = 1L;
private Label lblDocAction; private Label lblDocAction;
private Label label; private Label label;
private Listbox lstDocAction; private Listbox lstDocAction;
private static GridTab gridTab; private static GridTab gridTab;
private static String[] s_value = null; private static String[] s_value = null;
private static String[] s_name; private static String[] s_name;
private static String[] s_description; private static String[] s_description;
private String DocStatus; private String DocStatus;
private String DocAction; private String DocAction;
private int m_AD_Table_ID; private int m_AD_Table_ID;
private boolean m_OKpressed; private boolean m_OKpressed;
private ConfirmPanel confirmPanel; private ConfirmPanel confirmPanel;
private static final CLogger logger; private static final CLogger logger;
static static
{ {
logger = CLogger.getCLogger(WDocActionPanel.class); logger = CLogger.getCLogger(WDocActionPanel.class);
} }
public WDocActionPanel(GridTab mgridTab) public WDocActionPanel(GridTab mgridTab)
{ {
gridTab = mgridTab; gridTab = mgridTab;
DocStatus = (String)gridTab.getValue("DocStatus"); DocStatus = (String)gridTab.getValue("DocStatus");
DocAction = (String)gridTab.getValue("DocAction"); DocAction = (String)gridTab.getValue("DocAction");
m_AD_Table_ID = Env.getContextAsInt(Env.getCtx(), gridTab.getWindowNo(), "BaseTable_ID"); m_AD_Table_ID = Env.getContextAsInt(Env.getCtx(), gridTab.getWindowNo(), "BaseTable_ID");
readReference(); readReference();
initComponents(); initComponents();
dynInit(); dynInit();
init(); init();
this.setAttribute("mode","modal"); this.setAttribute("mode","modal");
} }
/** /**
* Dynamic Init - determine valid DocActions based on DocStatus for the different documents. * Dynamic Init - determine valid DocActions based on DocStatus for the different documents.
*/ */
private void dynInit() private void dynInit()
{ {
// //
Object Processing = gridTab.getValue("Processing"); Object Processing = gridTab.getValue("Processing");
String OrderType = Env.getContext(Env.getCtx(), gridTab.getWindowNo(), "OrderType"); String OrderType = Env.getContext(Env.getCtx(), gridTab.getWindowNo(), "OrderType");
@ -106,17 +106,17 @@ public class WDocActionPanel extends Window implements EventListener
//message.setText("*** ERROR ***"); //message.setText("*** ERROR ***");
return; return;
} }
logger.fine("DocStatus=" + DocStatus logger.fine("DocStatus=" + DocStatus
+ ", DocAction=" + DocAction + ", OrderType=" + OrderType + ", DocAction=" + DocAction + ", OrderType=" + OrderType
+ ", IsSOTrx=" + IsSOTrx + ", Processing=" + Processing + ", IsSOTrx=" + IsSOTrx + ", Processing=" + Processing
+ ", AD_Table_ID=" +gridTab.getAD_Table_ID() + ", Record_ID=" + gridTab.getRecord_ID()); + ", AD_Table_ID=" +gridTab.getAD_Table_ID() + ", Record_ID=" + gridTab.getRecord_ID());
int index = 0; int index = 0;
if(lstDocAction.getSelectedItem() != null) if(lstDocAction.getSelectedItem() != null)
{ {
String selected = (lstDocAction.getSelectedItem().getValue()).toString(); String selected = (lstDocAction.getSelectedItem().getValue()).toString();
for(int i = 0; i < s_value.length && index == 0; i++) for(int i = 0; i < s_value.length && index == 0; i++)
{ {
if(s_value[i].equals(selected)) if(s_value[i].equals(selected))
{ {
@ -124,18 +124,18 @@ public class WDocActionPanel extends Window implements EventListener
} }
} }
} }
String[] options = new String[s_value.length]; String[] options = new String[s_value.length];
/** /**
* Check Existence of Workflow Acrivities * Check Existence of Workflow Acrivities
*/ */
String wfStatus = MWFActivity.getActiveInfo(Env.getCtx(), m_AD_Table_ID, gridTab.getRecord_ID()); String wfStatus = MWFActivity.getActiveInfo(Env.getCtx(), m_AD_Table_ID, gridTab.getRecord_ID());
if (wfStatus != null) if (wfStatus != null)
{ {
FDialog.error(gridTab.getWindowNo(), this, "WFActiveForRecord", wfStatus); FDialog.error(gridTab.getWindowNo(), this, "WFActiveForRecord", wfStatus);
return; return;
} }
// Status Change // Status Change
if (!checkStatus(gridTab.getTableName(), gridTab.getRecord_ID(), DocStatus)) if (!checkStatus(gridTab.getTableName(), gridTab.getRecord_ID(), DocStatus))
{ {
@ -147,19 +147,31 @@ public class WDocActionPanel extends Window implements EventListener
*/ */
String[] docActionHolder = new String[]{DocAction}; String[] docActionHolder = new String[]{DocAction};
index = DocumentEngine.getValidActions(DocStatus, Processing, OrderType, IsSOTrx, index = DocumentEngine.getValidActions(DocStatus, Processing, OrderType, IsSOTrx,
m_AD_Table_ID, docActionHolder, options); m_AD_Table_ID, docActionHolder, options);
Integer doctypeId = (Integer)gridTab.getValue("C_DocType_ID");
if(doctypeId==null || doctypeId.intValue()==0){
doctypeId = (Integer)gridTab.getValue("C_DocTypeTarget_ID");
}
logger.fine("get doctype: " + doctypeId);
if (doctypeId != null) {
index = DocumentEngine.checkActionAccess(Env.getAD_Client_ID(Env.getCtx()),
Env.getAD_Role_ID(Env.getCtx()),
doctypeId, options, index);
}
DocAction = docActionHolder[0]; DocAction = docActionHolder[0];
/** /**
* Fill actionCombo * Fill actionCombo
*/ */
for (int i = 0; i < index; i++) for (int i = 0; i < index; i++)
{ {
// Serach for option and add it // Serach for option and add it
boolean added = false; boolean added = false;
for (int j = 0; j < s_value.length && !added; j++) for (int j = 0; j < s_value.length && !added; j++)
{ {
if (options[i].equals(s_value[j])) if (options[i].equals(s_value[j]))
@ -173,7 +185,7 @@ public class WDocActionPanel extends Window implements EventListener
for(Listitem item: lst) for(Listitem item: lst)
{ {
String value = item.getValue().toString(); String value = item.getValue().toString();
if(DocAction.equals(value)) if(DocAction.equals(value))
{ {
lstDocAction.setSelectedItem(item); lstDocAction.setSelectedItem(item);
@ -184,55 +196,55 @@ public class WDocActionPanel extends Window implements EventListener
if (DocAction.equals("--")) // If None, suggest closing if (DocAction.equals("--")) // If None, suggest closing
DocAction = DocumentEngine.ACTION_Close; DocAction = DocumentEngine.ACTION_Close;
} }
private boolean checkStatus (String TableName, int Record_ID, String DocStatus) private boolean checkStatus (String TableName, int Record_ID, String DocStatus)
{ {
String sql = "SELECT 2 FROM " + TableName String sql = "SELECT 2 FROM " + TableName
+ " WHERE " + TableName + "_ID=" + Record_ID + " WHERE " + TableName + "_ID=" + Record_ID
+ " AND DocStatus='" + DocStatus + "'"; + " AND DocStatus='" + DocStatus + "'";
int result = DB.getSQLValue(null, sql); int result = DB.getSQLValue(null, sql);
return result == 2; return result == 2;
} }
private void initComponents() private void initComponents()
{ {
lblDocAction = new Label(); lblDocAction = new Label();
lblDocAction.setId("lblDocAction"); lblDocAction.setId("lblDocAction");
lblDocAction.setValue(Msg.translate(Env.getCtx(), "DocAction")); lblDocAction.setValue(Msg.translate(Env.getCtx(), "DocAction"));
label = new Label(); label = new Label();
label.setId("label"); label.setId("label");
lstDocAction = new Listbox(); lstDocAction = new Listbox();
lstDocAction.setId("lstDocAction"); lstDocAction.setId("lstDocAction");
lstDocAction.setRows(0); lstDocAction.setRows(0);
lstDocAction.setMold("select"); lstDocAction.setMold("select");
lstDocAction.setWidth("100px"); lstDocAction.setWidth("100px");
lstDocAction.addEventListener(Events.ON_SELECT, this); lstDocAction.addEventListener(Events.ON_SELECT, this);
confirmPanel = new ConfirmPanel(true); confirmPanel = new ConfirmPanel(true);
confirmPanel.addActionListener(Events.ON_CLICK, this); confirmPanel.addActionListener(Events.ON_CLICK, this);
} }
private void init() private void init()
{ {
Grid grid = GridFactory.newGridLayout(); Grid grid = GridFactory.newGridLayout();
grid.setId("grd"); grid.setId("grd");
grid.setWidth("400px"); grid.setWidth("400px");
Rows rows = new Rows(); Rows rows = new Rows();
Row rowDocAction = new Row(); Row rowDocAction = new Row();
Row rowLabel = new Row(); Row rowLabel = new Row();
Row rowConfirm = new Row(); Row rowConfirm = new Row();
Row rowSpacer = new Row(); Row rowSpacer = new Row();
Panel pnlDocAction = new Panel(); Panel pnlDocAction = new Panel();
pnlDocAction.appendChild(lblDocAction); pnlDocAction.appendChild(lblDocAction);
pnlDocAction.appendChild(lstDocAction); pnlDocAction.appendChild(lstDocAction);
rowDocAction.appendChild(pnlDocAction); rowDocAction.appendChild(pnlDocAction);
rowDocAction.setAlign("right"); rowDocAction.setAlign("right");
rowLabel.appendChild(label); rowLabel.appendChild(label);
@ -242,15 +254,15 @@ public class WDocActionPanel extends Window implements EventListener
rows.appendChild(rowLabel); rows.appendChild(rowLabel);
rows.appendChild(rowSpacer); rows.appendChild(rowSpacer);
rows.appendChild(rowConfirm); rows.appendChild(rowConfirm);
grid.appendChild(rows); grid.appendChild(rows);
this.setTitle(Msg.translate(Env.getCtx(), "DocAction")); this.setTitle(Msg.translate(Env.getCtx(), "DocAction"));
this.setWidth("410px"); this.setWidth("410px");
this.setBorder("normal"); this.setBorder("normal");
this.appendChild(grid); this.appendChild(grid);
} }
/** /**
* Should the process be started? * Should the process be started?
* @return OK pressed * @return OK pressed
@ -262,7 +274,7 @@ public class WDocActionPanel extends Window implements EventListener
public void onEvent(Event event) public void onEvent(Event event)
{ {
if (Events.ON_CLICK.equals(event.getName())) if (Events.ON_CLICK.equals(event.getName()))
{ {
if (confirmPanel.getButton("Ok").equals(event.getTarget())) if (confirmPanel.getButton("Ok").equals(event.getTarget()))
@ -275,18 +287,18 @@ public class WDocActionPanel extends Window implements EventListener
{ {
m_OKpressed = false; m_OKpressed = false;
this.detach(); this.detach();
} }
} }
else if (Events.ON_SELECT.equals(event.getName())) else if (Events.ON_SELECT.equals(event.getName()))
{ {
if (lstDocAction.equals(event.getTarget())) if (lstDocAction.equals(event.getTarget()))
{ {
label.setValue(s_description[getSelectedIndex()]); label.setValue(s_description[getSelectedIndex()]);
} }
} }
} }
private void setValue() private void setValue()
{ {
int index = getSelectedIndex(); int index = getSelectedIndex();
@ -300,14 +312,14 @@ public class WDocActionPanel extends Window implements EventListener
ArrayList<String> v_value = new ArrayList<String>(); ArrayList<String> v_value = new ArrayList<String>();
ArrayList<String> v_name = new ArrayList<String>(); ArrayList<String> v_name = new ArrayList<String>();
ArrayList<String> v_description = new ArrayList<String>(); ArrayList<String> v_description = new ArrayList<String>();
DocumentEngine.readReferenceList(v_value, v_name, v_description); DocumentEngine.readReferenceList(v_value, v_name, v_description);
int size = v_value.size(); int size = v_value.size();
s_value = new String[size]; s_value = new String[size];
s_name = new String[size]; s_name = new String[size];
s_description = new String[size]; s_description = new String[size];
for (int i = 0; i < size; i++) for (int i = 0; i < size; i++)
{ {
s_value[i] = (String)v_value.get(i); s_value[i] = (String)v_value.get(i);
@ -315,15 +327,15 @@ public class WDocActionPanel extends Window implements EventListener
s_description[i] = (String)v_description.get(i); s_description[i] = (String)v_description.get(i);
} }
} // readReference } // readReference
public int getSelectedIndex() public int getSelectedIndex()
{ {
int index = 0; int index = 0;
if(lstDocAction.getSelectedItem() != null) if(lstDocAction.getSelectedItem() != null)
{ {
String selected = (lstDocAction.getSelectedItem().getValue()).toString(); String selected = (lstDocAction.getSelectedItem().getValue()).toString();
for(int i = 0; i < s_value.length && index == 0; i++) for(int i = 0; i < s_value.length && index == 0; i++)
{ {
if(s_value[i].equals(selected)) if(s_value[i].equals(selected))
{ {
@ -338,5 +350,5 @@ public class WDocActionPanel extends Window implements EventListener
public int getNumberOfOptions() { public int getNumberOfOptions() {
return lstDocAction != null ? lstDocAction.getItemCount() : 0; return lstDocAction != null ? lstDocAction.getItemCount() : 0;
} }
} }