From 52b0db967b7bbdb397998a62005734c2098213f5 Mon Sep 17 00:00:00 2001
From: Heng Sin Low <hengsin@gmail.com>
Date: Mon, 17 Dec 2007 17:33:54 +0000
Subject: [PATCH] [ 1705184 ] System.out messages in 2pack

---
 .../src/org/adempiere/pipo/PackInHandler.java | 20 ++++++++++++-------
 .../pipo/handler/ColumnElementHandler.java    |  6 ------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/base/src/org/adempiere/pipo/PackInHandler.java b/base/src/org/adempiere/pipo/PackInHandler.java
index ac95a90977..a450eef588 100644
--- a/base/src/org/adempiere/pipo/PackInHandler.java
+++ b/base/src/org/adempiere/pipo/PackInHandler.java
@@ -33,6 +33,7 @@ import java.util.Stack;
 import java.io.*;
 import java.text.SimpleDateFormat;
 import java.util.Date;
+import java.util.logging.Level;
 
 import javax.xml.transform.stream.StreamResult;
 import javax.xml.transform.sax.TransformerHandler;
@@ -116,7 +117,7 @@ public class PackInHandler extends DefaultHandler {
     private int m_AD_Client_ID = 0;
     private int AD_Package_Imp_ID=0;
 	private int AD_Package_Imp_Inst_ID=0;
-    private CLogger log = CLogger.getCLogger("PackIn");
+    private CLogger log = CLogger.getCLogger(PackInHandler.class);
     private OutputStream  fw_document = null;
     private TransformerHandler logDocument = null;
     private StreamResult streamResult_document = null;		
@@ -648,8 +649,10 @@ public class PackInHandler extends DefaultHandler {
 	    			handler.endElement(m_ctx, e);
 	    		if (e.defer)
 					defer.add(new DeferEntry(e, false));
-	    		else if (!e.skip)
-	    			System.out.println("Processed: " + e.getElementValue() + " - " + e.attributes.getValue(0));
+	    		else if (!e.skip) {
+	    			if (log.isLoggable(Level.INFO))
+	    				log.info("Processed: " + e.getElementValue() + " - " + e.attributes.getValue(0));
+	    		}
     		}
     	}
     }   // endElement
@@ -698,9 +701,11 @@ public class PackInHandler extends DefaultHandler {
     			}
     			if (d.element.defer)
     				defer.add(d);
-    			else if (!d.startElement)
-    				System.out.println("Processed: " + d.element.getElementValue() + " - " 
-    					+ d.element.attributes.getValue(0));
+    			else if (!d.startElement) {
+    				if (log.isLoggable(Level.INFO))
+    					log.info("Processed: " + d.element.getElementValue() + " - " 
+    							+ d.element.attributes.getValue(0));
+    			}
     		}
     		int endSize = defer.size();
     		if (startSize == endSize) break;
@@ -711,7 +716,8 @@ public class PackInHandler extends DefaultHandler {
     		for (DeferEntry d : defer) {
     			if (d.startElement) {
     				count++;
-    				System.out.println("Unresolved: " + d.element.getElementValue() + " - " + d.element.attributes.getValue(0) + ", " + d.element.unresolved);
+    				if (log.isLoggable(Level.INFO))
+    					log.info("Unresolved: " + d.element.getElementValue() + " - " + d.element.attributes.getValue(0) + ", " + d.element.unresolved);
     			}
     		}
     		throw new RuntimeException("Failed to resolve dependency for " + count + " elements.");
diff --git a/base/src/org/adempiere/pipo/handler/ColumnElementHandler.java b/base/src/org/adempiere/pipo/handler/ColumnElementHandler.java
index 8ffa7644ef..a51c63e5be 100644
--- a/base/src/org/adempiere/pipo/handler/ColumnElementHandler.java
+++ b/base/src/org/adempiere/pipo/handler/ColumnElementHandler.java
@@ -229,10 +229,6 @@ public class ColumnElementHandler extends AbstractElementHandler {
 					recreateColumn = false;
 			}
 
-			/*if (tableName.equals("A_Depreciation") && columnName.equals("Processed")) {
-				System.out.println("A_Depreciation.Processed: " + recreateColumn);
-			}*/
-			
 			if (m_Column.save(getTrxName(ctx)) == true) {
 				record_log(ctx, 1, m_Column.getName(), "Column", m_Column
 						.get_ID(), AD_Backup_ID, Object_Status, "AD_Column",
@@ -343,14 +339,12 @@ public class ColumnElementHandler extends AbstractElementHandler {
 				log.info(sql);
 	
 				if (sql.indexOf(DB.SQLSTATEMENT_SEPARATOR) == -1) {
-					System.out.println(sql);
 					no = DB.executeUpdate(sql, false, trx.getTrxName());
 					if (no == -1)
 						return 0;
 				} else {
 					String statements[] = sql.split(DB.SQLSTATEMENT_SEPARATOR);
 					for (int i = 0; i < statements.length; i++) {
-						System.out.println(statements[i]);
 						int count = DB.executeUpdate(statements[i], false,
 								trx.getTrxName());
 						if (count == -1) {