diff --git a/base/src/org/adempiere/pipo/PackIn.java b/base/src/org/adempiere/pipo/PackIn.java index 165caead3b..5c2d85d233 100644 --- a/base/src/org/adempiere/pipo/PackIn.java +++ b/base/src/org/adempiere/pipo/PackIn.java @@ -188,16 +188,16 @@ public class PackIn extends SvrProcess { PackIn packIn = new PackIn(); if (adPackageImp.isAD_Override_Dict() == true) - packIn.m_UpdateMode = "true"; + PackIn.m_UpdateMode = "true"; else - packIn.m_UpdateMode = "false"; + PackIn.m_UpdateMode = "false"; - packIn.m_Package_Dir = packageDirectory + File.separator + PackIn.m_Package_Dir = packageDirectory + File.separator + "packages" + File.separator + PackageName + File.separator; if (DB.isOracle()) - packIn.m_Database = "Oracle"; + PackIn.m_Database = "Oracle"; else if (DB.isPostgreSQL()) - packIn.m_Database = "PostgreSQL"; + PackIn.m_Database = "PostgreSQL"; // call XML Handler String msg = packIn.importXML(dict_file, getCtx(), get_TrxName()); @@ -243,7 +243,7 @@ public class PackIn extends SvrProcess { // Integer.valueOf(args[2]).intValue(), args[5], args[3], args[4]); CConnection cc = CConnection.get(); // System.out.println("DB Connect String1:"+cc.getDbName()); - packIn.m_Database = cc.getType(); + PackIn.m_Database = cc.getType(); DB.setDBTarget(cc); } @@ -285,7 +285,7 @@ public class PackIn extends SvrProcess { CLogMgt.setLoggerLevel(logLevel, null); if (args.length >= 8) - packIn.m_UpdateMode = args[7]; + PackIn.m_UpdateMode = args[7]; String trxName = Trx.createTrxName("PackIn"); try { diff --git a/base/src/org/adempiere/pipo/handler/CodeSnipitElementHandler.java b/base/src/org/adempiere/pipo/handler/CodeSnipitElementHandler.java index cf67fbf600..693129e7d7 100644 --- a/base/src/org/adempiere/pipo/handler/CodeSnipitElementHandler.java +++ b/base/src/org/adempiere/pipo/handler/CodeSnipitElementHandler.java @@ -88,7 +88,7 @@ public class CodeSnipitElementHandler extends AbstractElementHandler { } } - //Correct target directory for proper file seperator + //Correct target directory for proper file separator String fullDirectory = sourcePath+targetDirectory; String targetDirectoryModified=null; String fileDate = null; diff --git a/base/src/org/adempiere/process/InvoiceGenerateRMA.java b/base/src/org/adempiere/process/InvoiceGenerateRMA.java index 9dc59764c1..2490b57f42 100644 --- a/base/src/org/adempiere/process/InvoiceGenerateRMA.java +++ b/base/src/org/adempiere/process/InvoiceGenerateRMA.java @@ -50,8 +50,6 @@ public class InvoiceGenerateRMA extends SvrProcess private int m_created = 0; /** Invoice Date */ private Timestamp m_dateinvoiced = null; - /** Line Number */ - private int m_line = 0; /** * Prepare - e.g., get Parameters. diff --git a/base/src/org/adempiere/process/rpl/exp/ExportHelper.java b/base/src/org/adempiere/process/rpl/exp/ExportHelper.java index 235c9216d0..b82d476b3a 100644 --- a/base/src/org/adempiere/process/rpl/exp/ExportHelper.java +++ b/base/src/org/adempiere/process/rpl/exp/ExportHelper.java @@ -223,7 +223,6 @@ public class ExportHelper { * * @return Document */ - @SuppressWarnings("unchecked") public Document exportRecord (MEXPFormat exportFormat, String where , Integer ReplicationMode , String ReplicationType, Integer ReplicationEvent) throws Exception { MClient client = MClient.get (exportFormat.getCtx(), m_AD_Client_ID); diff --git a/base/src/org/compiere/FA/AssetDisposed.java b/base/src/org/compiere/FA/AssetDisposed.java index 8a9da75e69..38a79671a6 100644 --- a/base/src/org/compiere/FA/AssetDisposed.java +++ b/base/src/org/compiere/FA/AssetDisposed.java @@ -196,8 +196,7 @@ public class AssetDisposed extends SvrProcess MAssetChange change = new MAssetChange (getCtx(), 0, null); change.setA_Asset_ID(AssetDisposed.getA_Asset_ID()); change.setChangeType("DIS"); - MRefList RefList = new MRefList (getCtx(), 0, null); - change.setTextDetails(RefList.getListDescription (getCtx(),"A_Update_Type" , "DIS")); + change.setTextDetails(MRefList.getListDescription (getCtx(),"A_Update_Type" , "DIS")); change.setAssetDisposalDate(AssetDisposed.getA_Disposed_Date()); change.setAssetAccumDepreciationAmt(v_Balance); change.setIsFullyDepreciated(true); diff --git a/base/src/org/compiere/FA/CreateGLAsset.java b/base/src/org/compiere/FA/CreateGLAsset.java index 09bea0f3a2..0e5196ded3 100644 --- a/base/src/org/compiere/FA/CreateGLAsset.java +++ b/base/src/org/compiere/FA/CreateGLAsset.java @@ -219,8 +219,7 @@ public class CreateGLAsset extends SvrProcess change.setA_Depreciation_Variable_Perc(assetacct.getA_Depreciation_Variable_Perc()); change.setA_Parent_Asset_ID(asset.getA_Parent_Asset_ID()); change.setChangeType("CRT"); - MRefList RefList = new MRefList (getCtx(), 0, get_TrxName()); - change.setTextDetails(RefList.getListDescription (getCtx(),"A_Update_Type" , "CRT")); + change.setTextDetails(MRefList.getListDescription (getCtx(),"A_Update_Type" , "CRT")); change.setIsInPosession(asset.isOwned()); change.setIsDisposed(asset.isDisposed()); change.setIsDepreciated(asset.isDepreciated()); @@ -315,8 +314,7 @@ public class CreateGLAsset extends SvrProcess MAssetChange change = new MAssetChange (getCtx(), 0, get_TrxName()); change.setA_Asset_ID(asset.getA_Asset_ID()); change.setChangeType("ADD"); - MRefList RefList = new MRefList (getCtx(), 0, get_TrxName()); - change.setTextDetails(RefList.getListDescription (getCtx(),"A_Update_Type" , "ADD")); + change.setTextDetails(MRefList.getListDescription (getCtx(),"A_Update_Type" , "ADD")); change.setPostingType(assetwk.getPostingType()); change.setAssetValueAmt(assetadd.getAssetValueAmt()); change.setA_QTY_Current(assetadd.getA_QTY_Current()); @@ -357,8 +355,7 @@ public class CreateGLAsset extends SvrProcess change.setA_Asset_ID(asset.getA_Asset_ID()); change.setA_QTY_Current(assetadd.getA_QTY_Current()); change.setChangeType("EXP"); - MRefList RefList = new MRefList (getCtx(), 0, get_TrxName()); - change.setTextDetails(RefList.getListDescription (getCtx(),"A_Update_Type" , "EXP")); + change.setTextDetails(MRefList.getListDescription (getCtx(),"A_Update_Type" , "EXP")); assetadd.setPostingType("A"); change.setAssetValueAmt(assetadd.getAssetValueAmt()); change.setA_QTY_Current(assetadd.getA_QTY_Current()); diff --git a/base/src/org/compiere/FA/CreateInvoicedAsset.java b/base/src/org/compiere/FA/CreateInvoicedAsset.java index 5145372d5d..31dbae6cc7 100644 --- a/base/src/org/compiere/FA/CreateInvoicedAsset.java +++ b/base/src/org/compiere/FA/CreateInvoicedAsset.java @@ -238,9 +238,8 @@ public class CreateInvoicedAsset extends SvrProcess change.setA_Depreciation_Table_Header_ID(assetacct.getA_Depreciation_Table_Header_ID()); change.setA_Depreciation_Variable_Perc(assetacct.getA_Depreciation_Variable_Perc()); change.setA_Parent_Asset_ID(asset.getA_Parent_Asset_ID()); - change.setChangeType("CRT"); - MRefList RefList = new MRefList (getCtx(), 0, get_TrxName()); - change.setTextDetails(RefList.getListDescription (getCtx(),"A_Update_Type" , "CRT")); + change.setChangeType("CRT"); + change.setTextDetails(MRefList.getListDescription (getCtx(),"A_Update_Type" , "CRT")); change.setIsInPosession(asset.isOwned()); change.setIsDisposed(asset.isDisposed()); change.setIsDepreciated(asset.isDepreciated()); @@ -458,8 +457,7 @@ public class CreateInvoicedAsset extends SvrProcess change.setA_Asset_ID(asset.getA_Asset_ID()); change.setA_QTY_Current(assetadd.getA_QTY_Current()); change.setChangeType("ADD"); - MRefList RefList = new MRefList (getCtx(), 0, get_TrxName()); - change.setTextDetails(RefList.getListDescription (getCtx(),"A_Update_Type" , "ADD")); + change.setTextDetails(MRefList.getListDescription (getCtx(),"A_Update_Type" , "ADD")); change.setPostingType(assetwk.getPostingType()); change.setAssetValueAmt(assetadd.getAssetValueAmt()); change.setA_QTY_Current(assetadd.getA_QTY_Current()); @@ -555,8 +553,7 @@ public class CreateInvoicedAsset extends SvrProcess change.setA_Asset_ID(asset.getA_Asset_ID()); change.setA_QTY_Current(assetadd.getA_QTY_Current()); change.setChangeType("EXP"); - MRefList RefList = new MRefList (getCtx(), 0, get_TrxName()); - change.setTextDetails(RefList.getListDescription (getCtx(),"A_Update_Type" , "EXP")); + change.setTextDetails(MRefList.getListDescription (getCtx(),"A_Update_Type" , "EXP")); assetadd.setPostingType("A"); change.setAssetValueAmt(assetadd.getAssetValueAmt()); change.setA_QTY_Current(assetadd.getA_QTY_Current()); diff --git a/base/src/org/compiere/db/LDAP.java b/base/src/org/compiere/db/LDAP.java index 6b8a3b2315..3bc7257edc 100644 --- a/base/src/org/compiere/db/LDAP.java +++ b/base/src/org/compiere/db/LDAP.java @@ -167,12 +167,12 @@ public class LDAP /* Print each attribute */ try { - for (NamingEnumeration ae = attrs.getAll (); ae.hasMore ();) + for (NamingEnumeration ae = attrs.getAll (); ae.hasMore ();) { - Attribute attr = (Attribute) ae.next (); + Attribute attr = ae.next (); System.out.println ("attribute: " + attr.getID ()); /* print each value */ - for (NamingEnumeration e = attr.getAll(); + for (NamingEnumeration e = attr.getAll(); e.hasMore (); System.out.println (" value: " + e.next())) ; diff --git a/base/src/org/compiere/db/TestEJB.java b/base/src/org/compiere/db/TestEJB.java index 508ad9dbf7..899241a2ac 100644 --- a/base/src/org/compiere/db/TestEJB.java +++ b/base/src/org/compiere/db/TestEJB.java @@ -18,6 +18,7 @@ package org.compiere.db; import javax.naming.CommunicationException; import javax.naming.InitialContext; +import javax.naming.NameClassPair; import javax.naming.NamingEnumeration; import org.compiere.interfaces.Status; @@ -43,7 +44,7 @@ public class TestEJB { System.out.println(ic.getEnvironment()); System.out.println("----------------"); - NamingEnumeration ne = ic.list(""); + NamingEnumeration ne = ic.list(""); while (ne.hasMore()) { System.out.println(ne.next()); diff --git a/base/src/org/compiere/interfaces/Status.java b/base/src/org/compiere/interfaces/Status.java index 69a819a9d1..794c51b59e 100644 --- a/base/src/org/compiere/interfaces/Status.java +++ b/base/src/org/compiere/interfaces/Status.java @@ -1,7 +1,7 @@ package org.compiere.interfaces; /** - * Tnterface for adempiere/Status. + * Interface for adempiere/Status. */ public interface Status { diff --git a/base/src/org/compiere/model/MProductCategoryAcct.java b/base/src/org/compiere/model/MProductCategoryAcct.java index 8baf918f74..2a993a74a7 100644 --- a/base/src/org/compiere/model/MProductCategoryAcct.java +++ b/base/src/org/compiere/model/MProductCategoryAcct.java @@ -47,7 +47,7 @@ public class MProductCategoryAcct extends X_M_Product_Category_Acct public static MProductCategoryAcct get (Properties ctx, int M_Product_Category_ID, int C_AcctSchema_ID, String trxName) { - String key = ""+M_Product_Category_ID+"#"+C_AcctSchema_ID; + String key = M_Product_Category_ID+"#"+C_AcctSchema_ID; MProductCategoryAcct acct = s_cache.get(key); if (acct != null) return acct; diff --git a/base/src/org/compiere/util/Login.java b/base/src/org/compiere/util/Login.java index 0c94546650..93ec109a1e 100644 --- a/base/src/org/compiere/util/Login.java +++ b/base/src/org/compiere/util/Login.java @@ -155,7 +155,7 @@ public class Login * - Get Connection * - Compare User info *

- * Sets Conext with login info + * Sets Context with login info * @param cc connection * @param app_user user * @param app_pwd pwd @@ -193,7 +193,7 @@ public class Login *

* Compare User Info *

- * Sets Conext with login info + * Sets Context with login info * @param app_user Principal * @return role array or null if in error. * The error (NoDatabase, UserPwdError, DBLogin) is saved in the log @@ -211,7 +211,7 @@ public class Login *

* Compare User Info *

- * Sets Conext with login info + * Sets Context with login info * @param app_user user id * @param app_pwd password * @return role array or null if in error. diff --git a/client/src/org/compiere/grid/XLookup.java b/client/src/org/compiere/grid/XLookup.java index fd5d928b7f..4f057bb3f8 100644 --- a/client/src/org/compiere/grid/XLookup.java +++ b/client/src/org/compiere/grid/XLookup.java @@ -80,7 +80,7 @@ public class XLookup extends Lookup */ public boolean containsKey (Object key) { - // linear seatch in p_data + // linear search in p_data for (int i = 0; i < p_data.size(); i++) { Object oo = p_data.get(i); @@ -101,7 +101,7 @@ public class XLookup extends Lookup */ public NamePair get (Object key) { - // linear seatch in m_data + // linear search in m_data for (int i = 0; i < p_data.size(); i++) { Object oo = p_data.get(i); diff --git a/tools/src/org/apache/ecs/ElementAttributes.java b/tools/src/org/apache/ecs/ElementAttributes.java index f6a0176d15..bbed3ae7d7 100644 --- a/tools/src/org/apache/ecs/ElementAttributes.java +++ b/tools/src/org/apache/ecs/ElementAttributes.java @@ -273,7 +273,7 @@ public abstract class ElementAttributes extends GenericElement implements Attrib } /** Return a list of the attributes associated with this element. */ - public Enumeration attributes() + public Enumeration attributes() { return getElementHashEntry().keys(); } @@ -303,12 +303,12 @@ public abstract class ElementAttributes extends GenericElement implements Attrib } out.append(getElementType()); - Enumeration en = getElementHashEntry().keys(); + Enumeration en = getElementHashEntry().keys(); String value = null; // avoid creating a new string object on each pass through the loop while (en.hasMoreElements()) { - String attr = (String) en.nextElement(); + String attr = en.nextElement(); if(getAttributeFilterState()) { value = getAttributeFilter().process(getElementHashEntry().get(attr).toString()); diff --git a/tools/src/org/apache/ecs/ElementContainer.java b/tools/src/org/apache/ecs/ElementContainer.java index 5999f3a5e6..a63164258e 100644 --- a/tools/src/org/apache/ecs/ElementContainer.java +++ b/tools/src/org/apache/ecs/ElementContainer.java @@ -47,7 +47,7 @@ public class ElementContainer extends ConcreteElement implements Printable internal use only @serial ec ec */ - private Vector ec = new Vector(2); + private Vector ec = new Vector(2); /** Basic constructor @@ -90,7 +90,7 @@ public class ElementContainer extends ConcreteElement implements Printable public void output(OutputStream out) { Element element = null; - Enumeration data = ec.elements(); + Enumeration data = ec.elements(); while ( data.hasMoreElements() ) { element = (Element) data.nextElement(); @@ -104,7 +104,7 @@ public class ElementContainer extends ConcreteElement implements Printable public void output(PrintWriter out) { Element element = null; - Enumeration data = ec.elements(); + Enumeration data = ec.elements(); while ( data.hasMoreElements() ) { element = (Element) data.nextElement(); @@ -114,7 +114,7 @@ public class ElementContainer extends ConcreteElement implements Printable /** returns an enumeration of the elements in this container */ - public Enumeration elements() + public Enumeration elements() { return ec.elements(); } diff --git a/tools/src/org/apache/ecs/StringElement.java b/tools/src/org/apache/ecs/StringElement.java index 57db26f0f7..47b9059565 100644 --- a/tools/src/org/apache/ecs/StringElement.java +++ b/tools/src/org/apache/ecs/StringElement.java @@ -67,7 +67,7 @@ public class StringElement extends ConcreteElement implements Printable } /** - Resets the interal string to be empty. + Resets the internal string to be empty. */ public StringElement reset() {