FR [ 2694043 ] Query. first/firstOnly usage best practice

https://sourceforge.net/tracker/?func=detail&atid=879335&aid=2694043&group_id=176962
This commit is contained in:
teo_sarca 2009-03-19 21:46:29 +00:00
parent 857209220a
commit 2c5e0091e8
1 changed files with 5 additions and 4 deletions

View File

@ -26,7 +26,8 @@ import org.compiere.util.Language;
/** /**
* *
* @author hengsin * @author hengsin
* * @author Teo Sarca, www.arhipac.ro
* <li>FR [ 2694043 ] Query. first/firstOnly usage best practice
*/ */
public final class UserPreference implements Serializable { public final class UserPreference implements Serializable {
@ -86,7 +87,7 @@ public final class UserPreference implements Serializable {
String attribute = PROPERTIES[i]; String attribute = PROPERTIES[i];
String value = props.getProperty(attribute); String value = props.getProperty(attribute);
MPreference preference = query.setParameters(new Object[]{m_AD_User_ID, attribute}).first(); MPreference preference = query.setParameters(new Object[]{m_AD_User_ID, attribute}).firstOnly();
if (preference == null) { if (preference == null) {
preference = new MPreference(Env.getCtx(), 0, null); preference = new MPreference(Env.getCtx(), 0, null);
preference.setAD_User_ID(m_AD_User_ID); preference.setAD_User_ID(m_AD_User_ID);
@ -113,7 +114,7 @@ public final class UserPreference implements Serializable {
String attribute = PROPERTIES[i]; String attribute = PROPERTIES[i];
String value = VALUES[i]; String value = VALUES[i];
MPreference preference = query.setParameters(new Object[]{m_AD_User_ID, attribute}).first(); MPreference preference = query.setParameters(new Object[]{m_AD_User_ID, attribute}).firstOnly();
if (preference != null) { if (preference != null) {
value = preference.getValue(); value = preference.getValue();
} }
@ -134,7 +135,7 @@ public final class UserPreference implements Serializable {
for (int i = 0; i < PROPERTIES.length; i++) { for (int i = 0; i < PROPERTIES.length; i++) {
String attribute = PROPERTIES[i]; String attribute = PROPERTIES[i];
MPreference preference = query.setParameters(new Object[]{m_AD_User_ID, attribute}).first(); MPreference preference = query.setParameters(new Object[]{m_AD_User_ID, attribute}).firstOnly();
if (preference != null) { if (preference != null) {
preference.deleteEx(true); preference.deleteEx(true);
} }