midsuit
/
core-jgi
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BF [ 1874419 ] JDBC Statement not close in a finally block - for MUserQuery

This commit is contained in:
teo_sarca 2008-01-30 08:54:31 +00:00
parent 04232cb5c8
commit 1b5a943509
1 changed files with 10 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
base/src/org/compiere/model/MUserQuery.java
View File

@ -45,31 +45,24 @@ public class MUserQuery extends X_AD_UserQuery
int AD_Client_ID = Env.getAD_Client_ID (ctx); int AD_Client_ID = Env.getAD_Client_ID (ctx);
ArrayList<MUserQuery> list = new ArrayList<MUserQuery>(); ArrayList<MUserQuery> list = new ArrayList<MUserQuery>();
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, null); pstmt = DB.prepareStatement (sql, null);
pstmt.setInt (1, AD_Client_ID); pstmt.setInt (1, AD_Client_ID);
pstmt.setInt (2, AD_Tab_ID); pstmt.setInt (2, AD_Tab_ID);
ResultSet rs = pstmt.executeQuery(); rs = pstmt.executeQuery();
while (rs.next ()) while (rs.next ())
list.add(new MUserQuery (ctx, rs, null)); list.add(new MUserQuery (ctx, rs, null));
rs.close ();
pstmt.close ();
pstmt = null;
} }
catch (Exception e) catch (Exception e)
{ {
s_log.log (Level.SEVERE, sql, e); s_log.log (Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
MUserQuery[] retValue = new MUserQuery[list.size()]; MUserQuery[] retValue = new MUserQuery[list.size()];
list.toArray(retValue); list.toArray(retValue);
@ -95,32 +88,25 @@ public class MUserQuery extends X_AD_UserQuery
name = "%"; name = "%";
MUserQuery retValue = null; MUserQuery retValue = null;
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, null); pstmt = DB.prepareStatement (sql, null);
pstmt.setInt (1, AD_Client_ID); pstmt.setInt (1, AD_Client_ID);
pstmt.setInt (2, AD_Tab_ID); pstmt.setInt (2, AD_Tab_ID);
pstmt.setString (3, name.toUpperCase()); pstmt.setString (3, name.toUpperCase());
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
if (rs.next ()) if (rs.next ())
retValue = new MUserQuery (ctx, rs, null); retValue = new MUserQuery (ctx, rs, null);
rs.close ();
pstmt.close ();
pstmt = null;
} }
catch (Exception e) catch (Exception e)
{ {
s_log.log (Level.SEVERE, sql, e); s_log.log (Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
return retValue; return retValue;
} // get } // get