From 09de60d04c5b270284f2868d3c0583fea5dc1c37 Mon Sep 17 00:00:00 2001 From: Heng Sin Low Date: Mon, 2 Jul 2007 04:57:13 +0000 Subject: [PATCH] [ 1746266 ] Convert fails for type only ALTER...MODIFY statement --- base/src/org/compiere/dbPort/Convert_PostgreSQL.java | 4 ++-- base/src/org/compiere/dbPort/Convert_PostgreSQLTest.java | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/base/src/org/compiere/dbPort/Convert_PostgreSQL.java b/base/src/org/compiere/dbPort/Convert_PostgreSQL.java index 89925327da..c0bd822515 100644 --- a/base/src/org/compiere/dbPort/Convert_PostgreSQL.java +++ b/base/src/org/compiere/dbPort/Convert_PostgreSQL.java @@ -1000,8 +1000,8 @@ public class Convert_PostgreSQL extends Convert_SQL92 { else { int typeEnd = rest.indexOf(' '); - type = rest.substring(0, typeEnd).trim(); - rest = rest.substring(typeEnd); + type = typeEnd > 0 ? rest.substring(0, typeEnd).trim() : rest; + rest = typeEnd > 0 ? rest.substring(typeEnd) : ""; } if (rest.toUpperCase().indexOf(" DEFAULT ") != -1) { diff --git a/base/src/org/compiere/dbPort/Convert_PostgreSQLTest.java b/base/src/org/compiere/dbPort/Convert_PostgreSQLTest.java index 32352201bd..abe28ec6dd 100644 --- a/base/src/org/compiere/dbPort/Convert_PostgreSQLTest.java +++ b/base/src/org/compiere/dbPort/Convert_PostgreSQLTest.java @@ -78,6 +78,12 @@ public final class Convert_PostgreSQLTest extends TestCase{ sqe = "ALTER TABLE XX ADD COLUMN A VARCHAR(10) DEFAULT '--'"; r = convert.convert(sql); assertEquals(sqe, r[0].trim()); + + //[ adempiere-Bugs-1746266 ] + sql = "ALTER TABLE someTableName MODIFY someColumnName NVARCHAR2(64)"; + sqe = "insert into t_alter_column values('sometablename','someColumnName','VARCHAR(64)',null,null)"; + r = convert.convert(sql); + assertEquals(sqe, r[0].trim()); } // Convert.recoverQuotedStrings() error on strings with "<-->" - teo_sarca [ 1705768 ]