From 069bc5e5ba6e4d1c78af9ccad1f43b641bfc34d8 Mon Sep 17 00:00:00 2001 From: Carlos Ruiz Date: Sat, 13 Oct 2018 10:33:53 +0200 Subject: [PATCH] IDEMPIERE-2771 Improve 2pack tracing for errors / AP2-694 Packin sometimes notifies Success when is a Failure --- .../src/org/adempiere/pipo/srv/PipoDictionaryService.java | 3 ++- org.adempiere.pipo/src/org/adempiere/pipo2/PackInProcess.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/org.adempiere.pipo/src/org/adempiere/pipo/srv/PipoDictionaryService.java b/org.adempiere.pipo/src/org/adempiere/pipo/srv/PipoDictionaryService.java index 18f79c12d3..c1f4885a50 100644 --- a/org.adempiere.pipo/src/org/adempiere/pipo/srv/PipoDictionaryService.java +++ b/org.adempiere.pipo/src/org/adempiere/pipo/srv/PipoDictionaryService.java @@ -111,7 +111,8 @@ public class PipoDictionaryService implements IDictionaryService { if (logger.isLoggable(Level.INFO)) logger.info("commit " + trxName); } catch (Exception e) { adPackageImp.setP_Msg(e.getLocalizedMessage()); - packIn.getNotifier().addStatusLine(e.getLocalizedMessage()); + packIn.getNotifier().addFailureLine(e.getLocalizedMessage()); + packIn.setSuccess(false); logger.log(Level.SEVERE, "importXML:", e); throw e; } finally { diff --git a/org.adempiere.pipo/src/org/adempiere/pipo2/PackInProcess.java b/org.adempiere.pipo/src/org/adempiere/pipo2/PackInProcess.java index 8bcfd56027..250aae0b39 100644 --- a/org.adempiere.pipo/src/org/adempiere/pipo2/PackInProcess.java +++ b/org.adempiere.pipo/src/org/adempiere/pipo2/PackInProcess.java @@ -147,7 +147,8 @@ public class PackInProcess extends SvrProcess { commitEx(); // we need to commit to capture HERE when the deferred validation of foreign keys can fail } catch (Exception e) { adPackageImp.setP_Msg(e.getLocalizedMessage()); - packIn.getNotifier().addStatusLine(e.getLocalizedMessage()); + packIn.getNotifier().addFailureLine(e.getLocalizedMessage()); + packIn.setSuccess(false); log.log(Level.SEVERE, "importXML:", e); throw e; } finally {